gh-98896: Fix parsing issue in resource_tracker to allow shared memory names containing colons #138473
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rani-pinchuk
force-pushed
the
fix-shm-colon
branch
from
13ca553 to
d973cf0
Compare
encukou
reviewed
Nov 4, 2025
Comment on lines
+288
to
+293
| parts = line.strip().decode('ascii').split(':') | ||
| if len(parts) < 3: | ||
| raise ValueError("malformed resource_tracker message: %r" % (parts,)) | ||
| cmd = parts[0] | ||
| rtype = parts[-1] | ||
| name = ':'.join(parts[1:-1]) |
There was a problem hiding this comment.
How about this?
Suggested change
| parts = line.strip().decode('ascii').split(':') | |
| if len(parts) < 3: | |
| raise ValueError("malformed resource_tracker message: %r" % (parts,)) | |
| cmd = parts[0] | |
| rtype = parts[-1] | |
| name = ':'.join(parts[1:-1]) | |
| cmd, *name_parts, rtype = line.strip().decode('ascii').split(':') | |
| name = ':'.join(name_parts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared memory names containing colons were not parsed correctly as the code of
resource_trackerassumed that these names contain no colons.@encukou